-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add several types to PGAdapter #1887
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagotnunes
force-pushed
the
pg-types
branch
from
September 23, 2024 03:19
6b9630c
to
b18b194
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1887 +/- ##
============================================
+ Coverage 43.98% 51.73% +7.75%
+ Complexity 3457 1283 -2174
============================================
Files 827 372 -455
Lines 49052 20247 -28805
Branches 5141 2038 -3103
============================================
- Hits 21576 10475 -11101
+ Misses 25829 9116 -16713
+ Partials 1647 656 -991
|
thiagotnunes
force-pushed
the
pg-types
branch
2 times, most recently
from
September 29, 2024 13:08
0bf7a91
to
c56eeaf
Compare
thiagotnunes
force-pushed
the
pg-types
branch
from
September 29, 2024 13:12
c56eeaf
to
442eed9
Compare
Adds 60+ different type mappings for the PostgreSQL adapter.
thiagotnunes
force-pushed
the
pg-types
branch
from
September 29, 2024 13:12
442eed9
to
e886cfc
Compare
.../cloud/teleport/v2/source/reader/io/jdbc/rowmapper/provider/PostgreSQLJdbcValueMappings.java
Outdated
Show resolved
Hide resolved
.../cloud/teleport/v2/source/reader/io/jdbc/rowmapper/provider/PostgreSQLJdbcValueMappings.java
Show resolved
Hide resolved
.../cloud/teleport/v2/source/reader/io/jdbc/rowmapper/provider/PostgreSQLJdbcValueMappings.java
Show resolved
Hide resolved
.../cloud/teleport/v2/source/reader/io/jdbc/rowmapper/provider/PostgreSQLJdbcValueMappings.java
Show resolved
Hide resolved
Simplifies code and add testing for unsupported types.
VardhanThigle
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds several type mappings for a PostgreSQL database.