Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add several types to PGAdapter #1887

Merged
merged 6 commits into from
Oct 3, 2024

Conversation

thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Sep 23, 2024

Adds several type mappings for a PostgreSQL database.

  • bigint
  • bigserial
  • bit
  • bit varying
  • bool
  • boolean
  • bytea
  • char
  • character
  • character varying
  • date
  • decimal
  • double precision
  • float4
  • float8
  • int
  • integer
  • int2
  • int4
  • int8
  • json
  • jsonb
  • money
  • numeric
  • oid
  • real
  • serial
  • serial2
  • serial4
  • serial8
  • smallint
  • smallserial
  • text
  • timestamp
  • timestamptz
  • timestamp with time zone
  • timestamp without time zone
  • uuid
  • varbit
  • varchar

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.73%. Comparing base (ab97ff6) to head (d90947e).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...owmapper/provider/PostgreSQLJdbcValueMappings.java 94.73% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1887      +/-   ##
============================================
+ Coverage     43.98%   51.73%   +7.75%     
+ Complexity     3457     1283    -2174     
============================================
  Files           827      372     -455     
  Lines         49052    20247   -28805     
  Branches       5141     2038    -3103     
============================================
- Hits          21576    10475   -11101     
+ Misses        25829     9116   -16713     
+ Partials       1647      656     -991     
Components Coverage Δ
spanner-templates 66.49% <96.42%> (+2.90%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 74.80% <ø> (-0.44%) ⬇️
spanner-live-reverse-replication 75.50% <ø> (+7.12%) ⬆️
spanner-bulk-migration 84.50% <96.42%> (+0.21%) ⬆️
Files with missing lines Coverage Δ
...ypemapping/provider/PostgreSQLMappingProvider.java 100.00% <100.00%> (ø)
...owmapper/provider/PostgreSQLJdbcValueMappings.java 95.78% <94.73%> (-4.22%) ⬇️

... and 507 files with indirect coverage changes

Adds 60+ different type mappings for the PostgreSQL adapter.
Simplifies code and add testing for unsupported types.
@VardhanThigle VardhanThigle merged commit 162cee1 into GoogleCloudPlatform:main Oct 3, 2024
13 checks passed
@thiagotnunes thiagotnunes deleted the pg-types branch October 7, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants