Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for runner_v2 tests #1875

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

Polber
Copy link
Contributor

@Polber Polber commented Sep 17, 2024

Needed to test staging runner v2 worker images against Template ITs

Tests are run against latest release tag for repo to avoid running against broken tests as much as possible

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 43.95%. Comparing base (9926a2e) to head (6b62b11).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
.../java/org/apache/beam/it/gcp/TemplateTestBase.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1875      +/-   ##
============================================
+ Coverage     43.31%   43.95%   +0.64%     
- Complexity     3515     3754     +239     
============================================
  Files           832      827       -5     
  Lines         48676    49008     +332     
  Branches       5242     5138     -104     
============================================
+ Hits          21082    21540     +458     
+ Misses        25899    25817      -82     
+ Partials       1695     1651      -44     
Components Coverage Δ
spanner-templates 63.46% <ø> (-0.19%) ⬇️
spanner-import-export 63.79% <ø> (-0.03%) ⬇️
spanner-live-forward-migration 75.05% <ø> (-0.07%) ⬇️
spanner-live-reverse-replication 68.21% <ø> (-0.73%) ⬇️
spanner-bulk-migration 84.12% <ø> (-0.08%) ⬇️
Files with missing lines Coverage Δ
.../java/org/apache/beam/it/gcp/TemplateTestBase.java 0.00% <0.00%> (ø)

... and 110 files with indirect coverage changes

@Polber Polber force-pushed the jkinard/uw-tests branch 2 times, most recently from 652c37f to c2cb186 Compare September 18, 2024 18:15
Signed-off-by: Jeffrey Kinard <[email protected]>
@Polber Polber marked this pull request as ready for review September 18, 2024 18:53
@Polber
Copy link
Contributor Author

Polber commented Sep 18, 2024

Test failures are unrelated - This PR does not affect existing tests

damccorm
damccorm previously approved these changes Sep 19, 2024
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM

.github/workflows/uw-tests.yml Outdated Show resolved Hide resolved
Signed-off-by: Jeffrey Kinard <[email protected]>
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Polber Polber merged commit fa89a15 into GoogleCloudPlatform:main Sep 20, 2024
26 of 29 checks passed
dedocibula pushed a commit to dedocibula/DataflowTemplates that referenced this pull request Sep 20, 2024
* Add workflow for runner_v2 tests

Signed-off-by: Jeffrey Kinard <[email protected]>

* Rename runner to unified worker

Signed-off-by: Jeffrey Kinard <[email protected]>

---------

Signed-off-by: Jeffrey Kinard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants