Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable default splunk and confluent dependencies #1785

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

Polber
Copy link
Contributor

@Polber Polber commented Aug 12, 2024

  • Removes need to specify -PsplunkDeps,missing-artifact-repos when building project and running tests.
    • Disabling profiles now requires specifying -DskipSplunkDeps and -DskipConfluentDeps
  • Fixes site report plugin as part of release.
  • Adds artifact registry repo as part of release process for managing dependencies during release

Fixes #1737
Fixes #1548

@Polber Polber self-assigned this Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.97%. Comparing base (ffdb13c) to head (26cba9d).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1785   +/-   ##
=========================================
  Coverage     42.96%   42.97%           
  Complexity     3398     3398           
=========================================
  Files           816      816           
  Lines         47687    47687           
  Branches       5123     5123           
=========================================
+ Hits          20491    20493    +2     
+ Misses        25534    25531    -3     
- Partials       1662     1663    +1     
Components Coverage Δ
spanner-templates 63.74% <ø> (-0.01%) ⬇️
spanner-import-export 64.31% <ø> (-0.03%) ⬇️
spanner-live-forward-migration 75.17% <ø> (ø)
spanner-live-reverse-replication 71.62% <ø> (ø)
spanner-bulk-migration 83.63% <ø> (ø)
Files Coverage Δ
.../java/org/apache/beam/it/gcp/TemplateTestBase.java 0.00% <ø> (ø)
...taflow/FlexTemplateDataflowJobResourceManager.java 17.24% <ø> (ø)

... and 2 files with indirect coverage changes

@Polber Polber force-pushed the jkinard/disable-profiles branch 2 times, most recently from e3ace6f to b97a8de Compare August 13, 2024 18:23
Signed-off-by: Jeffrey Kinard <[email protected]>
@Polber Polber requested review from damccorm and Abacn August 13, 2024 18:28
@Polber Polber marked this pull request as ready for review August 13, 2024 18:28
@Abacn
Copy link
Contributor

Abacn commented Aug 13, 2024

Thanks, does this resolve #1737 ?

@Polber
Copy link
Contributor Author

Polber commented Aug 13, 2024

Thanks, does this resolve #1737 ?

Yes it does as well as #1548

@Polber Polber merged commit 87ae0eb into GoogleCloudPlatform:main Aug 13, 2024
15 checks passed
@mataralhawiti
Copy link

mataralhawiti commented Aug 18, 2024

thank you @Polber for your effort. Unfortunately, I'm still getting the same error in #1548

[ERROR] Failed to execute goal on project mysql-to-googlecloud: Could not resolve dependencies for project com.google.cloud.teleport.v2:mysql-to-googlecloud:jar:1.0-SNAPSHOT: Failed to collect dependencies at com.google.cloud.teleport.v2:jdbc-to-googlecloud:jar:1.0-SNAPSHOT: Failed to read artifact descriptor for com.google.cloud.teleport.v2:jdbc-to-googlecloud:jar:1.0-SNAPSHOT: Could not transfer artifact com.google.cloud.teleport.v2:jdbc-to-googlecloud:pom:1.0-SNAPSHOT from/to splunk-artifactory (https://splunk.jfrog.io/splunk/ext-releases-local): Transfer failed for https://splunk.jfrog.io/splunk/ext-releases-local/com/google/cloud/teleport/v2/jdbc-to-googlecloud/1.0-SNAPSHOT/jdbc-to-googlecloud-1.0-SNAPSHOT.pom 409 -> [Help 1]

trying to check URL https://splunk.jfrog.io/ui/native/ext-releases-local/com/google/cloud/teleport/v2/jdbc-to-googlecloud/1.0-SNAPSHOT/jdbc-to-googlecloud-1.0-SNAPSHOT.pom

I got :
{ "errors": [ { "status": 404, "message": "Item ext-releases-local:com/google/cloud/teleport/v2/jdbc-to-googlecloud/1.0-SNAPSHOT does not exist" } ] }

@Polber
Copy link
Contributor Author

Polber commented Sep 10, 2024

@mataralhawiti That is a different error - the error this PR fixes is not downloading confluent and splunk dependencies from their corresponding repos unless the corresponding profiles were specified. That behavior is now the default.

You are getting an error that the jdbc-to-googlecloud project could not be found. More specifically, you are getting that error when trying to build the mysql-to-googlecloud module which lists the jdbc-to-googlecloud module as a dependency.

This should not be happening unless you are trying to build the mysql-to-googlecloud module without first building the jdbc-to-googlecloud project. You can pass -am when running mvn compile (or related command) to first build dependencies of a given module.

I suggest running mvn clean compile from the root directory or specify mvn clean compile -pl mysql-to-googlecloud -am from the root directory

@zachberger
Copy link
Member

Perhaps that info should be included on the per template build instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants