-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable default splunk and confluent dependencies #1785
Enable default splunk and confluent dependencies #1785
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1785 +/- ##
=========================================
Coverage 42.96% 42.97%
Complexity 3398 3398
=========================================
Files 816 816
Lines 47687 47687
Branches 5123 5123
=========================================
+ Hits 20491 20493 +2
+ Misses 25534 25531 -3
- Partials 1662 1663 +1
|
e3ace6f
to
b97a8de
Compare
Signed-off-by: Jeffrey Kinard <[email protected]>
b97a8de
to
b546c13
Compare
Signed-off-by: Jeffrey Kinard <[email protected]>
b546c13
to
26cba9d
Compare
Thanks, does this resolve #1737 ? |
thank you @Polber for your effort. Unfortunately, I'm still getting the same error in #1548
trying to check URL I got : |
@mataralhawiti That is a different error - the error this PR fixes is not downloading confluent and splunk dependencies from their corresponding repos unless the corresponding profiles were specified. That behavior is now the default. You are getting an error that the This should not be happening unless you are trying to build the I suggest running |
Perhaps that info should be included on the per template build instructions. |
-PsplunkDeps,missing-artifact-repos
when building project and running tests.-DskipSplunkDeps
and-DskipConfluentDeps
Fixes #1737
Fixes #1548