Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test for source writer #1749

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Conversation

aksharauke
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.77%. Comparing base (983c151) to head (2608dc5).
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1749      +/-   ##
============================================
+ Coverage     42.15%   42.77%   +0.61%     
- Complexity     3278     3684     +406     
============================================
  Files           808      815       +7     
  Lines         47293    47678     +385     
  Branches       5053     5107      +54     
============================================
+ Hits          19938    20394     +456     
+ Misses        25710    25627      -83     
- Partials       1645     1657      +12     
Components Coverage Δ
spanner-templates 63.06% <100.00%> (+1.59%) ⬆️
spanner-import-export 64.42% <ø> (-0.03%) ⬇️
spanner-live-forward-migration 75.06% <ø> (+0.29%) ⬆️
spanner-live-reverse-replication 68.73% <100.00%> (+2.61%) ⬆️
spanner-bulk-migration 83.65% <ø> (+1.21%) ⬆️
Files Coverage Δ
...leport/v2/templates/transforms/SourceWriterFn.java 32.14% <100.00%> (+32.14%) ⬆️

... and 24 files with indirect coverage changes

@aksharauke aksharauke marked this pull request as ready for review July 26, 2024 11:29
Copy link
Contributor

@darshan-sj darshan-sj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aksharauke aksharauke merged commit 2e7e782 into GoogleCloudPlatform:main Aug 1, 2024
21 of 22 checks passed
@aksharauke aksharauke deleted the rr branch August 1, 2024 04:38
dhercher pushed a commit that referenced this pull request Aug 1, 2024
* source writer unit test

* added git configs for new template

* added spanner pr workflow

* added spanner pr workflow

* added spanner pr workflow
damccorm pushed a commit that referenced this pull request Aug 3, 2024
* adding logging to test schemmap

* open schemmap prtection

* Handling for String Primary Keys in Bulk Reader. (#1743)

Limitation: For the current PR complete support only upto 3 byte code points.

* Add support for ALO in SpannerChangeStreamsToBigQuery template (#1750)

* Fixing exception in String .isSplittable (#1755)

* Remove PIP_NO_DEPS from YamlTemplate Dockerfile (#1748)

Signed-off-by: Jeffrey Kinard <[email protected]>

* Terraform template updates for custom transformation (#1746)

* terraform changes for end-to-end template

* terraform updates

* formatting fix

* Add string mapper case for IT (#1757)

* Fixing Index Discovery for 5.7 and removing innodb_parallel_read_threads from init sequences for MySql5.7 compliance. (#1758)

* adding schema map to dml handler

* removing logs for testing

* ut for reverse replication shadow tables (#1759)

* ut for reverse replication shadow tables

* incorporated review comments

* unit test for source writer (#1749)

* source writer unit test

* added git configs for new template

* added spanner pr workflow

* added spanner pr workflow

* added spanner pr workflow

* Adding autoReconnect parameters to URL (#1760)

* map should not be static

* merging

* adding logging to test schemmap

* open schemmap prtection

* adding schema map to dml handler

* removing logs for testing

* map should not be static

* linebreaks

---------

Signed-off-by: Jeffrey Kinard <[email protected]>
Co-authored-by: Vardhan Vinay Thigle <[email protected]>
Co-authored-by: Dip Patel <[email protected]>
Co-authored-by: Jeff Kinard <[email protected]>
Co-authored-by: shreyakhajanchi <[email protected]>
Co-authored-by: Deep1998 <[email protected]>
Co-authored-by: aksharauke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants