-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unit test for source writer #1749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1749 +/- ##
============================================
+ Coverage 42.15% 42.77% +0.61%
- Complexity 3278 3684 +406
============================================
Files 808 815 +7
Lines 47293 47678 +385
Branches 5053 5107 +54
============================================
+ Hits 19938 20394 +456
+ Misses 25710 25627 -83
- Partials 1645 1657 +12
|
darshan-sj
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dhercher
pushed a commit
that referenced
this pull request
Aug 1, 2024
* source writer unit test * added git configs for new template * added spanner pr workflow * added spanner pr workflow * added spanner pr workflow
damccorm
pushed a commit
that referenced
this pull request
Aug 3, 2024
* adding logging to test schemmap * open schemmap prtection * Handling for String Primary Keys in Bulk Reader. (#1743) Limitation: For the current PR complete support only upto 3 byte code points. * Add support for ALO in SpannerChangeStreamsToBigQuery template (#1750) * Fixing exception in String .isSplittable (#1755) * Remove PIP_NO_DEPS from YamlTemplate Dockerfile (#1748) Signed-off-by: Jeffrey Kinard <[email protected]> * Terraform template updates for custom transformation (#1746) * terraform changes for end-to-end template * terraform updates * formatting fix * Add string mapper case for IT (#1757) * Fixing Index Discovery for 5.7 and removing innodb_parallel_read_threads from init sequences for MySql5.7 compliance. (#1758) * adding schema map to dml handler * removing logs for testing * ut for reverse replication shadow tables (#1759) * ut for reverse replication shadow tables * incorporated review comments * unit test for source writer (#1749) * source writer unit test * added git configs for new template * added spanner pr workflow * added spanner pr workflow * added spanner pr workflow * Adding autoReconnect parameters to URL (#1760) * map should not be static * merging * adding logging to test schemmap * open schemmap prtection * adding schema map to dml handler * removing logs for testing * map should not be static * linebreaks --------- Signed-off-by: Jeffrey Kinard <[email protected]> Co-authored-by: Vardhan Vinay Thigle <[email protected]> Co-authored-by: Dip Patel <[email protected]> Co-authored-by: Jeff Kinard <[email protected]> Co-authored-by: shreyakhajanchi <[email protected]> Co-authored-by: Deep1998 <[email protected]> Co-authored-by: aksharauke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.