Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatastreamToSQL - log schema map details #1747

Merged
merged 23 commits into from
Aug 3, 2024
Merged

DatastreamToSQL - log schema map details #1747

merged 23 commits into from
Aug 3, 2024

Conversation

dhercher
Copy link
Contributor

Adding logging to test schema map usage

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 42.87%. Comparing base (fc4ca2b) to head (07f387a).
Report is 2 commits behind head on main.

Files Patch % Lines
...google/cloud/teleport/v2/transforms/CreateDml.java 0.00% 4 Missing ⚠️
...e/cloud/teleport/v2/templates/DataStreamToSQL.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1747      +/-   ##
============================================
- Coverage     42.88%   42.87%   -0.02%     
+ Complexity     3401     3398       -3     
============================================
  Files           815      815              
  Lines         47718    47721       +3     
  Branches       5111     5111              
============================================
- Hits          20464    20459       -5     
- Misses        25596    25603       +7     
- Partials       1658     1659       +1     
Components Coverage Δ
spanner-templates 63.36% <ø> (-0.02%) ⬇️
spanner-import-export 64.40% <ø> (-0.05%) ⬇️
spanner-live-forward-migration 75.13% <ø> (ø)
spanner-live-reverse-replication 69.82% <ø> (ø)
spanner-bulk-migration 83.69% <ø> (ø)
Files Coverage Δ
...oogle/cloud/teleport/v2/utils/DatastreamToDML.java 7.85% <100.00%> (ø)
...e/cloud/teleport/v2/templates/DataStreamToSQL.java 4.68% <0.00%> (-0.08%) ⬇️
...google/cloud/teleport/v2/transforms/CreateDml.java 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@dhercher dhercher requested a review from a team as a code owner July 30, 2024 18:36
@dhercher dhercher added size/XS and removed size/XXL labels Jul 31, 2024
dhercher and others added 9 commits August 1, 2024 18:24
* ut for reverse replication shadow tables

* incorporated review comments
* source writer unit test

* added git configs for new template

* added spanner pr workflow

* added spanner pr workflow

* added spanner pr workflow
@dhercher dhercher requested a review from damccorm August 2, 2024 02:54
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@damccorm damccorm merged commit 7e784de into main Aug 3, 2024
15 of 17 checks passed
@damccorm damccorm deleted the ds2sql-add-logging branch August 3, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants