Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datastream to sql IT's #1697

Merged

Conversation

Polber
Copy link
Contributor

@Polber Polber commented Jun 28, 2024

No description provided.

@Polber Polber requested review from Abacn and damccorm June 28, 2024 01:22
@Polber Polber self-assigned this Jun 28, 2024
@Polber Polber force-pushed the jkinard/datastream-sql branch 5 times, most recently from 80d03be to d54d2be Compare July 3, 2024 16:01
Signed-off-by: Jeffrey Kinard <[email protected]>
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 29.88506% with 61 lines in your changes missing coverage. Please review.

Project coverage is 41.23%. Comparing base (0bcf179) to head (7e440c4).
Report is 67 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1697      +/-   ##
============================================
- Coverage     41.25%   41.23%   -0.03%     
+ Complexity     3240     2936     -304     
============================================
  Files           771      772       +1     
  Lines         45127    45209      +82     
  Branches       4819     4826       +7     
============================================
+ Hits          18619    18640      +21     
- Misses        24940    24996      +56     
- Partials       1568     1573       +5     
Components Coverage Δ
spanner-templates 61.25% <ø> (ø)
spanner-import-export 64.36% <ø> (ø)
spanner-live-forward-migration 74.14% <ø> (ø)
spanner-live-reverse-replication 50.56% <ø> (ø)
spanner-bulk-migration 80.63% <ø> (ø)
Files Coverage Δ
...eam/it/gcp/cloudsql/CloudMySQLResourceManager.java 83.33% <60.00%> (-16.67%) ⬇️
.../beam/it/gcp/cloudsql/CloudSqlResourceManager.java 79.48% <85.71%> (+1.02%) ⬆️
...am/it/gcp/cloudsql/CloudOracleResourceManager.java 70.58% <61.11%> (-14.42%) ⬇️
.../it/gcp/cloudsql/CloudPostgresResourceManager.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@damccorm damccorm mentioned this pull request Jul 3, 2024
@Polber
Copy link
Contributor Author

Polber commented Jul 9, 2024

@damccorm Do you mind taking a look when you get a chance?

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just had one question

@Polber Polber requested a review from damccorm July 11, 2024 17:23
@damccorm damccorm added the Google LGTM Approval of a pull request to be merged into the repository label Jul 11, 2024
@copybara-service copybara-service bot merged commit e19dcbc into GoogleCloudPlatform:main Jul 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Google LGTM Approval of a pull request to be merged into the repository size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants