-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datastream to sql IT's #1697
Add datastream to sql IT's #1697
Conversation
80d03be
to
d54d2be
Compare
Signed-off-by: Jeffrey Kinard <[email protected]>
d54d2be
to
7e440c4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
============================================
- Coverage 41.25% 41.23% -0.03%
+ Complexity 3240 2936 -304
============================================
Files 771 772 +1
Lines 45127 45209 +82
Branches 4819 4826 +7
============================================
+ Hits 18619 18640 +21
- Misses 24940 24996 +56
- Partials 1568 1573 +5
|
@damccorm Do you mind taking a look when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just had one question
...loud-platform/src/test/java/org/apache/beam/it/gcp/cloudsql/CloudSqlResourceManagerTest.java
Show resolved
Hide resolved
e19dcbc
into
GoogleCloudPlatform:main
No description provided.