Merge pull request #1308 from Polber:jkinard/private-connectivity

PiperOrigin-RevId: 603433059
GoogleCloudPlatform · Feb 1, 2024 · 5493788 · 5493788
2 parents 76f6580 + 7f5d564
commit 5493788
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/cicd/internal/flags/it-flags.go b/cicd/internal/flags/it-flags.go
@@ -76,7 +76,7 @@ func HostIp() string {
 }
 
 func PrivateConnectivity() string {
-	if dPrivateConnectivity == "" {
+	if dPrivateConnectivity != "" {
 		return "-DprivateConnectivity=" + dPrivateConnectivity
 	}
 	return ""

diff --git a/cicd/internal/workflows/maven-workflows.go b/cicd/internal/workflows/maven-workflows.go
@@ -204,6 +204,13 @@ func RunForChangedModules(cmd string, args ...string) error {
 		return nil
 	}
 
+	parsedArgs := []string{}
+	for _, arg := range args {
+		if arg != "" {
+			parsedArgs = append(parsedArgs, arg)
+		}
+	}
+
 	// Collect the modules together for a single call. Maven can work out the install order.
 	modules := make([]string, 0)
 
@@ -265,7 +272,7 @@ func RunForChangedModules(cmd string, args ...string) error {
 
 	modules = append(modules, "plugins/templates-maven-plugin")
 
-	return op.RunMavenOnModule(unifiedPom, cmd, strings.Join(modules, ","), args...)
+	return op.RunMavenOnModule(unifiedPom, cmd, strings.Join(modules, ","), parsedArgs...)
 }
 
 type spotlessCheckWorkflow struct{}