Java8 ByteBuffer.flip returnType #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbun |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## branch-2.2.x #974 +/- ##
==================================================
+ Coverage 80.99% 81.13% +0.13%
- Complexity 2237 2250 +13
==================================================
Files 154 156 +2
Lines 10342 10369 +27
Branches 1209 1211 +2
==================================================
+ Hits 8377 8413 +36
+ Misses 1447 1442 -5
+ Partials 518 514 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
abmodi
approved these changes
Mar 6, 2023
| @@ -131,7 +132,7 @@ public Boolean call() throws Exception { | |||
| } | |||
| byteBuffer.put(data.toByteArray()); | |||
| // switch to read mode | |||
| byteBuffer.flip(); | |||
| ((Buffer) byteBuffer).flip(); | |||
There was a problem hiding this comment.
Why we are doing this? What will happen if we do not do this?
Also, add a comment here.
There was a problem hiding this comment.
It is covered as part of PR description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating use of
BuyteBuffer.flip()for Java8 plasma-umass/doppio#497 (comment) explains the issue very well.