Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SQL query to compare impact of using auto-sizes plugin for sizes=auto functionality #162

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

felixarntz
Copy link
Collaborator

@felixarntz felixarntz commented Oct 3, 2024

This PR's query takes the approach from #108 and uses it in a comparison over time, specifically focused on determining the impact of the sizes="auto" addition from the Enhanced Responsive Images plugin (slug: auto-sizes). The relevant feature was recently committed to WordPress Core.

It compares sites that were using the plugin in 2024-06 with the same intersection of sites not using the plugin in 2024-05. It then also considers only images with the same URL on the same site, to get as close to a consistent dataset as possible.

The timeframe was chosen because it needs to be before 2024-07, as in July version 1.1.0 of the plugin introduced additional functionality which we don't want to influence the result. Additionally, the choice of comparing between adjacent months was made so that there's the least possible room for changes on each site that could skew the data.

Query results

Since the raw query results are so large, please see this spreadsheet.

The spreadsheet also contains a summary of the diff in another tab, as well as the results of a similar query that gets the LCP passing rate of these sites before and after, as another reference point. For the CrUX data, it uses the approach from https://colab.research.google.com/drive/1TmbJhSBuM-gTHA_E_W96pSjraQkFYpyi#scrollTo=XoNNe9GNW2hm.

@joemcgill
Copy link
Collaborator

Thanks! I think this is a nice way of seeing the impact.

It's worth noting that this query will include images that do not get auto-sizes applied (e.g. non lazy-loaded images), even when the plugin is added so the impact on affected images might be even greater. Would that require a new custom metric, like image.hasAutoSizes? If so, should we try adding a new custom metric for that prior to the WP 6.7 release?

It's also nice to see a positive correlation between adding this plugin and improved LCP passing rates. There are other possible factors that could have affected the LCP passing rates on those URLs, but this certainly is a positive sign.

@felixarntz felixarntz merged commit 6da568c into main Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants