Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the final report readme #398

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Added the final report readme #398

merged 2 commits into from
Aug 30, 2024

Conversation

professorabhay
Copy link
Collaborator

@professorabhay professorabhay commented Aug 26, 2024

Here is the readme version of the final report!

Ready to merge.

I'll make a commit in that PR to update the readme file after accomplishing the goal of package creation and documenting the result of the comparison.

@professorabhay professorabhay added the gsoc24 Google Summer of Code 2024 label Aug 26, 2024
@professorabhay professorabhay self-assigned this Aug 26, 2024
@hoch hoch changed the title Added the final report readme [WIP] Added the final report readme Aug 27, 2024
@mjwilson-google
Copy link
Collaborator

@professorabhay is this ready for review now?

@professorabhay
Copy link
Collaborator Author

Yes, It is!

@mjwilson-google mjwilson-google changed the title [WIP] Added the final report readme Added the final report readme Aug 30, 2024
Copy link
Collaborator

@mjwilson-google mjwilson-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

For the performance comparison and packaging guide, were you still planning on adding them to the github wiki? Either way, it would be good to link to them from this document as well.

@mjwilson-google
Copy link
Collaborator

I'll merge this now but please either add wiki pages or links to your blog posts about the packaging and comparison, so that we have a record of it in this repo.

@mjwilson-google mjwilson-google merged commit 5906e71 into main Aug 30, 2024
5 checks passed
@professorabhay
Copy link
Collaborator Author

I already created the wiki pages.
image
image

@mjwilson-google
Copy link
Collaborator

I already created the wiki pages.

I see them, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc24 Google Summer of Code 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants