Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #362 - Implemented PR352: One-Pole Filter Audio Worklet, Updated Noise-Generator, Volume-Meter, and Audio-Worklet-Node-Options #390

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

tarunsinghofficial
Copy link
Contributor

Fixes #362 implemented the PR352 - one-pole-filter audio worklet sample.

Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your contribution!

@tarunsinghofficial
Copy link
Contributor Author

Hi @hoch

All 4 examples are now completed. It's now ready to merge.

@duojet2ez
Copy link
Contributor

We discussed having separate pull requests for each example rather than completing all four in a single PR.

@tarunsinghofficial
Copy link
Contributor Author

We discussed having separate pull requests for each example rather than completing all four in a single PR.

So, shall I create separate PRs for each task?

@hoch
Copy link
Member

hoch commented Aug 16, 2024

Thanks for sharing your thoughts, @duojet2ez!

I think the scope of this PR is adequate - now we found a common pattern that works reasonably well for all examples, so the review was also fast.

@hoch
Copy link
Member

hoch commented Aug 16, 2024

There's a check failing and I'll have to take a look at what's going on.

@hoch
Copy link
Member

hoch commented Aug 16, 2024

@tarunsinghofficial Could you please update the title of PR to reflect the increased scope?

@tarunsinghofficial
Copy link
Contributor Author

tarunsinghofficial commented Aug 16, 2024

@tarunsinghofficial Could you please update the title of PR to reflect the increased scope?

Sure. Updated the title of the PR. Let me know if it's correct. Thanks

@tarunsinghofficial tarunsinghofficial changed the title Updated one-pole-filter audioworklet Fixes #362 - Implemented PR352: One-Pole Filter Audio Worklet, Updated Noise-Generator, Volume-Meter, and Audio-Worklet-Node-Options Aug 16, 2024
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit. Could you fix them before we merge this?

src/audio-worklet/basic/one-pole-filter/main.js Outdated Show resolved Hide resolved
@hoch hoch merged commit 15af0c2 into GoogleChromeLabs:main Aug 20, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants