Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: High level aggregated CSV download for sitemaps. #814

Merged
merged 12 commits into from
Aug 28, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Aug 22, 2024

Description

This PR aims to allow users to download aggregated CSV data when analysing a sitemap.

Relevant Technical Choices

  • A new function to generate aggregated CSV has been introduced to calculate the aggregated data of the sitemap.

Testing Instructions

  • Clone this branch
  • In the terminal run npm run build:cli:dashboard.
  • Then run analysis on a sitemap.
  • After analysis is done, open the report and download the report from sitemap landing page.
  • You should see a report.csv in the zip file, which will contain the data of the landing page.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #809

@amovar18 amovar18 changed the base branch from main to develop August 22, 2024 08:15
@amovar18 amovar18 self-assigned this Aug 23, 2024
@amovar18 amovar18 marked this pull request as ready for review August 23, 2024 14:27
@amovar18 amovar18 requested a review from mohdsayed August 26, 2024 11:27
Copy link
Collaborator

@mohdsayed mohdsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mohdsayed mohdsayed changed the base branch from develop to release/v0.11.0 August 28, 2024 09:56
@mohdsayed mohdsayed added this to the v0.11 milestone Aug 28, 2024
@mohdsayed mohdsayed merged commit d42100e into release/v0.11.0 Aug 28, 2024
6 checks passed
@mohdsayed mohdsayed deleted the feat/aggregated-cs-reports branch August 28, 2024 09:57
@milindmore22 milindmore22 mentioned this pull request Sep 2, 2024
32 tasks
@mohdsayed mohdsayed mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Aggregated CSV format for downloaded PSAT CLI Report
2 participants