Change OpenAPI backend generator config #4376
Conversation
| @@ -57,7 +57,7 @@ def do_get(self, **kwargs) -> dict[str, list[dict[str, Any]]]: | |||
| # Note: We assume that anyone may view approvals. | |||
| votes = Vote.get_votes(feature_id=feature_id, gate_id=gate_id) | |||
| dicts = [converters.vote_value_to_json_dict(v) for v in votes] | |||
| return GetVotesResponse.from_dict({'votes': dicts}).to_dict() | |||
| return GetVotesResponse.model_construct(votes=dicts).to_dict() | |||
There was a problem hiding this comment.
| return GetVotesResponse.model_construct(votes=dicts).to_dict() | |
| return GetVotesResponse.from_dict({'votes': dicts}).to_dict() |
model_construct takes in the expected object type for each argument. (votes should expect a variable of type List[Votes]). However, this is a special case where the existing code does this special conversion to dictionaries first. So instead, you can use the class method from_dict.
There was a problem hiding this comment.
This did not work either. This indeed helps convert the dict to model and then using to_dict() to convert it back, but it seems like the serialization & deserialization during the process changed the order of stuff we put in the dict and therefore differ from the test case. How would you suggest circumventing this situation?
There was a problem hiding this comment.
What error are you seeing? When I tried this suggestion earlier, the test started passing.
There was a problem hiding this comment.
i got
FAIL: test_do_get__success (api.reviews_api_test.GatesAPITest.test_do_get__success) Handler retrieves all gates associated with a given feature. Traceback (most recent call last): File "/opt/homebrew/Cellar/[email protected]/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/unittest/mock.py", line 1375, in patched return func(*newargs, **newkeywargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/mark/chromium-dashboard/api/reviews_api_test.py", line 349, in test_do_get__success self.assertEqual(actual, expected) AssertionError: {'gat[126 chars]e', 'state': 1, 'assignee_emails': [], 'additi[125 chars]ne}]} != {'gat[126 chars]e', 'escalation_email': None, 'state': 1, 'req[265 chars]']}]} Diff is 674 characters long. Set self.maxDiff to None to see it. Looks like the order is still messed up. The only change I made was to undo the changes in the current commit to return GetVotesResponse.from_dict({'votes': dicts}).to_dict()
-g changed from python-flask to python