Add main menu link for annual roadmap. #4332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleJu
approved these changes
Sep 27, 2024
jcscottiii
reviewed
Sep 27, 2024
| @@ -261,6 +261,12 @@ export class ChromedashDrawer extends LitElement { | |||
| const myFeaturesMenu = this.renderMyFeaturesMenu(); | |||
| const adminMenu = this.renderAdminMenu(); | |||
|
|
|||
| const year = new Date().getFullYear(); | |||
There was a problem hiding this comment.
Just a heads-up for Jan 1: This will cause a lot of the playwright screenshot tests to break when the link changes from Shipping 2024 to Shipping 2025.
There was a problem hiding this comment.
Good point. I'll follow up with a PR to elide that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds just one link to the main nav to show a query for shipping_year=2024 (or whatever the current year is). From there, the user can change the query in the search box.
Also, fix
@statevs@propertyso that the typeahead value can be passed in from the page (which gets it from the URL).