Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a search query option for the addwidget dialog #81

Merged
merged 16 commits into from
Aug 18, 2024

Conversation

DanPeled
Copy link
Contributor

@DanPeled DanPeled commented Aug 2, 2024

Wasnt sure how to write the test for this, if you (the reviewer) will be able to explain me / do it ill be glad

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 98.48485% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.58%. Comparing base (bcb85f7) to head (986d539).
Report is 1 commits behind head on main.

Files Patch % Lines
lib/widgets/network_tree/networktables_tree.dart 98.27% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   63.41%   63.58%   +0.16%     
==========================================
  Files          75       75              
  Lines        7867     7892      +25     
==========================================
+ Hits         4989     5018      +29     
+ Misses       2878     2874       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872
Copy link
Owner

Gold872 commented Aug 10, 2024

For adding unit tests, what would be the most practical to test the new features is to set up a mock NT connection with several sub-topics, and entering different search queries into the text box, and making sure that only certain tables are visible after searching

@Gold872 Gold872 merged commit 8710c7f into Gold872:main Aug 18, 2024
5 checks passed
Gold872 added a commit that referenced this pull request Aug 18, 2024
Gold872 added a commit that referenced this pull request Aug 18, 2024
Gold872 added a commit that referenced this pull request Aug 18, 2024
Gold872 added a commit that referenced this pull request Aug 18, 2024
@DanPeled DanPeled deleted the search_query branch August 18, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants