Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci lint: ignore teoretical xml tag name conflicts #103

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

isimluk
Copy link
Member

@isimluk isimluk commented Nov 20, 2023

Addressing:

  Running [/home/runner/golangci-lint-1.55.2-linux-amd64/golangci-lint run --out-format=github-actions --out-${NO_FUTURE}format colored-line-number] in [] ...
  Error: pkg/xsd/attribute.go:18:28: SA5008: invalid XML tag: name "-" conflicts with name "attribute" in *github.com/gocomply/xsd2go/pkg/xsd.Attribute.XMLName (staticcheck)
  	refAttr        *Attribute `xml:"-"`
  	                          ^
  Error: pkg/xsd/attribute.go:20:28: SA5008: invalid XML tag: name "-" conflicts with name "schema" in *github.com/gocomply/xsd2go/pkg/xsd.Schema.XMLName (staticcheck)
  	schema         *Schema    `xml:"-"`
  	                          ^
  Error: pkg/xsd/attributegroup.go:15:31: SA5008: invalid XML tag: name "-" conflicts with name "schema" in *github.com/gocomply/xsd2go/pkg/xsd.Schema.XMLName (staticcheck)
  	schema           *Schema     `xml:"-"`
  	                             ^
  Error: pkg/xsd/choice.go:13:25: SA5008: invalid XML tag: name "-" conflicts with name "schema" in *github.com/gocomply/xsd2go/pkg/xsd.Schema.XMLName (staticcheck)
  	schema      *Schema    `xml:"-"`
  	                       ^
  Error: pkg/xsd/element.go:22:31: SA5008: invalid XML tag: name "-" conflicts with name "element" in *github.com/gocomply/xsd2go/pkg/xsd.Element.XMLName (staticcheck)
  	refElm          *Element     `xml:"-"`
  	                             ^

Addressing:
  Running [/home/runner/golangci-lint-1.55.2-linux-amd64/golangci-lint run --out-format=github-actions --out-${NO_FUTURE}format colored-line-number] in [] ...
  Error: pkg/xsd/attribute.go:18:28: SA5008: invalid XML tag: name "-" conflicts with name "attribute" in *github.com/gocomply/xsd2go/pkg/xsd.Attribute.XMLName (staticcheck)
  	refAttr        *Attribute `xml:"-"`
  	                          ^
  Error: pkg/xsd/attribute.go:20:28: SA5008: invalid XML tag: name "-" conflicts with name "schema" in *github.com/gocomply/xsd2go/pkg/xsd.Schema.XMLName (staticcheck)
  	schema         *Schema    `xml:"-"`
  	                          ^
  Error: pkg/xsd/attributegroup.go:15:31: SA5008: invalid XML tag: name "-" conflicts with name "schema" in *github.com/gocomply/xsd2go/pkg/xsd.Schema.XMLName (staticcheck)
  	schema           *Schema     `xml:"-"`
  	                             ^
  Error: pkg/xsd/choice.go:13:25: SA5008: invalid XML tag: name "-" conflicts with name "schema" in *github.com/gocomply/xsd2go/pkg/xsd.Schema.XMLName (staticcheck)
  	schema      *Schema    `xml:"-"`
  	                       ^
  Error: pkg/xsd/element.go:22:31: SA5008: invalid XML tag: name "-" conflicts with name "element" in *github.com/gocomply/xsd2go/pkg/xsd.Element.XMLName (staticcheck)
  	refElm          *Element     `xml:"-"`
  	                             ^
@isimluk isimluk merged commit 505fa2d into GoComply:master Nov 20, 2023
8 of 12 checks passed
@isimluk isimluk deleted the ci-lint-ignores branch November 20, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant