[qofinstance.cpp] GValue on stack instead of heap

Gnucash · Oct 15, 2024 · e146210 · e146210
1 parent 635b213
commit e146210
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/libgnucash/engine/qofinstance.cpp b/libgnucash/engine/qofinstance.cpp
@@ -1340,17 +1340,16 @@ struct wrap_param
 static void
 wrap_gvalue_function (const char* key, KvpValue *val, wrap_param & param)
 {
-    GValue *gv;
-    gv = g_slice_new0 (GValue);
+    GValue gv;
     if (val->get_type() != KvpValue::Type::FRAME)
-        gvalue_from_kvp_value(val, gv);
+        gvalue_from_kvp_value(val, &gv);
     else
     {
-        g_value_init (gv, G_TYPE_STRING);
-        g_value_set_string (gv, nullptr);
+        g_value_init (&gv, G_TYPE_STRING);
+        g_value_set_string (&gv, nullptr);
     }
-    param.proc(key, gv, param.user_data);
-    g_slice_free (GValue, gv);
+    param.proc(key, &gv, param.user_data);
+    g_value_unset (&gv);
 }
 
 void