Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent snapping fixes #85

Merged
merged 3 commits into from
May 18, 2024
Merged

Prevent snapping fixes #85

merged 3 commits into from
May 18, 2024

Conversation

meronz
Copy link
Member

@meronz meronz commented May 18, 2024

I tested the features introduced in PR #79 and found a few issues.

  • The feature did not work when tabs were enabled. I made it work using the same technique used by USE_MODIFIER
  • The helping overlay did not show again when the SUPER key was released after it being pressed.
  • I made the PREVENT_SNAPPING setting mutually exclusive with USE_MODIFIER, since it is not useful to support them both at the same time.

@asteinba could you test these fixes and provide feedback? I think that everything should work fine as I tested all the combinations possible (tabs/no tabs, multiple zones/no multiple zones, etc.).

@meronz
Copy link
Member Author

meronz commented May 18, 2024

I'm going to merge this anyway since it is working for me. Let me know if there are any issues, so that i can hotfix them!

@meronz meronz merged commit d02e3f5 into main May 18, 2024
1 check passed
@meronz meronz deleted the issues/prevent-snapping-fixes branch May 18, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant