code review comments

GlossGenius · Jan 25, 2024 · b6fd0cb · b6fd0cb
1 parent 0ddfb37
commit b6fd0cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/main/java/com/eppo/sdk/dto/AssignmentLogData.java b/src/main/java/com/eppo/sdk/dto/AssignmentLogData.java
@@ -14,6 +14,7 @@ public class AssignmentLogData {
     public String featureFlag;
     public String allocation;
     public String variation;
+    public String variationName;
     public EppoValue variationValue;
     public Date timestamp;
     public String subject;
@@ -31,8 +32,9 @@ public AssignmentLogData(
         this.experiment = experiment;
         this.featureFlag = featureFlag;
         this.allocation = allocation;
+        this.variationName = variationName;
         this.variationValue = variationValue;
-        this.variation = variationName;
+        this.variation = variationValue.toString();
         this.timestamp = new Date();
         this.subject = subject;
         this.subjectAttributes = subjectAttributes;

diff --git a/src/main/java/com/eppo/sdk/dto/Variation.java b/src/main/java/com/eppo/sdk/dto/Variation.java
@@ -1,7 +1,6 @@
 package com.eppo.sdk.dto;
 
 import lombok.Data;
-import lombok.EqualsAndHashCode;
 
 /**
  * Experiment's Variation Class