Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation and Design Refactoring #50

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

WRH1997
Copy link

@WRH1997 WRH1997 commented Mar 28, 2023

Here are some implementation and design-level refactoring that I hope could be beneficial to the maintainability, understandability, and testability of your project.

3 implementation-level refactorings have been implemented. Namely:

  • Extracting Method in the AbstractunmodMap class
  • Decomposing Conditional & Introducing Explaining Variables in the RangeofInt class
  • Renaming Variables in the Tuple2 class

Additionally, 3 design-level refactorings have been implemented:

  • Replacing Conditional with Polymorphism in the RrbTree class
  • Moving Method in the PersistentTreeMap class
  • Extracting Class in the RangeOfInt class

Attached is a document detailing these changes for reference:
Refactoring Description.pdf

@GlenKPeterson
Copy link
Owner

I gave this a quick once-over and intend to come back and review it more carefully. I am honored that you or your professor chose this code to review! It looks like you ran a tool against this code. What tool or tools? I'll give some feedback on a few individual files now, and hopefully circle back for some bigger-picture comments later.

@GlenKPeterson
Copy link
Owner

GlenKPeterson commented Mar 29, 2023

I need to open the larger changes in an IDE to review them when I have more time. Maybe on the weekend? Thank you again for your attention to this project. Even if I don't accept proposed changes, the act of considering each one should make the project better. Feel free to disagree or explain.

@WRH1997
Copy link
Author

WRH1997 commented Mar 29, 2023

Thank you for your attention towards this pull request. I appreciate your kind words! Please take your time in reviewing the changes - no rush. As for the tool used, it was DesigniteJava, which my professor, Dr. Tushar Sharma at Dalhousie University, had a hand in developing. Even if the changes are rejected, I appreciate your time reviewing them. Please let me know if anything needs explanation or if you would like some changes implemented to my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants