Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : chore: Update EditChart component to include device features threshold options #2118

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Terdious
Copy link
Contributor

@Terdious Terdious commented Sep 5, 2024

…d options

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

https://community.gladysassistant.com/t/pouvoir-avoir-une-courbe-meme-si-la-valeur-ne-bouge-pas/9074

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (e27288e) to head (b9c81d4).
Report is 48 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2118   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         867      867           
  Lines       14187    14209   +22     
=======================================
+ Hits        13972    13994   +22     
  Misses        215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Sep 5, 2024

#2801 Bundle Size — 10.26MiB (+0.24%).

b9c81d4(current) vs b8ab133 master#2800(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 2 regressions
                 Current
#2801
     Baseline
#2800
Regression  Initial JS 5.56MiB(+0.44%) 5.54MiB
Regression  Initial CSS 304.83KiB(+0.05%) 304.68KiB
Change  Cache Invalidation 56.89% 0%
No change  Chunks 51 51
No change  Assets 171 171
Change  Modules 1493(+0.07%) 1492
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#2801
     Baseline
#2800
Regression  JS 7.35MiB (+0.34%) 7.32MiB
No change  IMG 2.48MiB 2.48MiB
Regression  CSS 321.62KiB (+0.05%) 321.47KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch Terdious:add-fixed-or-variable-t...Project dashboard


Generated by RelativeCIDocumentationReport issue

@Pierre-Gilles Pierre-Gilles changed the title chore: Update EditChart component to include device features threshol… WIP : chore: Update EditChart component to include device features threshold options Oct 4, 2024
Copy link

stale bot commented Dec 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant