Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alarm widget name is optional #1933

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Screenshot 2023-11-06 at 14 47 30
Screenshot 2023-11-06 at 14 47 34

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2ec30a4
Status: ✅  Deploy successful!
Preview URL: https://50a84327.gladys-plus.pages.dev
Branch Preview URL: https://optional-name-alarm-widget.gladys-plus.pages.dev

View logs

Copy link

relativeci bot commented Nov 6, 2023

Job #2011: Bundle Size — 8.98MiB (~+0.01%).

2ec30a4(current) vs 05f53c4 master#1978(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
Job #2011
     Baseline
Job #1978
Regression  Initial JS 4.84MiB(~+0.01%) 4.84MiB
No change  Initial CSS 301.85KiB 301.85KiB
No change  Cache Invalidation 63.26% 63.26%
No change  Chunks 51 51
No change  Assets 157 157
No change  Modules 1395 1395
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #2011
     Baseline
Job #1978
Regression  JS 6.49MiB (~+0.01%) 6.49MiB
Not changed  IMG 2.06MiB 2.06MiB
Not changed  CSS 318.08KiB 318.08KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 16.06KiB 16.06KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2011 reportView optional-name-alarm-widget branch activity

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
server/models/dashboard.js 100.00% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@Pierre-Gilles Pierre-Gilles merged commit e80d719 into master Nov 6, 2023
@Pierre-Gilles Pierre-Gilles deleted the optional-name-alarm-widget branch November 6, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant