Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat philips hue improve scan #1920

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Feat philips hue improve scan #1920

merged 5 commits into from
Nov 10, 2023

Conversation

cicoub13
Copy link
Contributor

@cicoub13 cicoub13 commented Oct 30, 2023 •
edited
Loading

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Following multiple issues about Philips Hue discovery, this PR allow to:

  • Enable both N-UPnP and UPnP search
  • Allow user to manually enter Philips Hue local bridge IP address to configure it

TODO:

  • Improve documentation (to explain that bridge should be registered through Philips Hue Application before using N-UPnP search)
  • Improve documentation to add the manual configuration
  • Ask for users to do real test use cases (Docker image under build)

cicoub13 and others added 2 commits October 29, 2023 10:55
@cicoub13
feat(philips-hue): N-UPnP Search + manual configuration from IP
afbd554 
- Add N-UPnP search during scan
- Need to revamp connect to get serial from configuration (not available from scan)
- Add a form in frontend to connect by manual IP
@cicoub13
feat(philips-hue): Make font work + style
cf5e60f
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
server/services/philips-hue/api/hue.controller.js 100.00% <100.00%> (ø)
server/services/philips-hue/lib/light/index.js 100.00% <100.00%> (ø)
...ces/philips-hue/lib/light/light.configureBridge.js 96.00% <100.00%> (+9.04%) ⬆️
...services/philips-hue/lib/light/light.getBridges.js 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!

@relativeci
Copy link

relativeci bot commented Oct 30, 2023 •
edited
Loading

Job #2025: Bundle Size — 8.99MiB (+0.02%).

418f7ce(current) vs 86cd2dd master#2015(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #2025		      Baseline
Job #2015
Regression  Initial JS 4.84MiB(+0.04%) 4.84MiB
No change  Initial CSS 301.85KiB 301.85KiB
Change  Cache Invalidation 53.74% 63.26%
No change  Chunks 51 51
No change  Assets 157 157
No change  Modules 1395 1395
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #2025		      Baseline
Job #2015
Regression  JS 6.49MiB (+0.03%) 6.49MiB
Not changed  IMG 2.06MiB 2.06MiB
Not changed  CSS 318.08KiB 318.08KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 16.06KiB 16.06KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2025 report View cicoub13:feat-philips-hue-improv... branch activity

Pierre-Gilles
Pierre-Gilles approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! 👏 Good for me!

@Pierre-Gilles Pierre-Gilles merged commit 7c173cf into GladysAssistant:master Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Gilles Pierre-Gilles Pierre-Gilles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cicoub13 @Pierre-Gilles