Add Alarm Modes

[Pierre-Gilles]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
• If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

Description of change

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	617e3b7
Status:	✅  Deploy successful!
Preview URL:	https://ccd453eb.gladys-plus.pages.dev
Branch Preview URL:	https://alarm-mode.gladys-plus.pages.dev

View logs

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
server/api/controllers/house.controller.js	100.00% <100.00%> (ø)
server/api/controllers/session.controller.js	100.00% <100.00%> (ø)
server/api/middlewares/errorMiddleware.js	91.66% <100.00%> (+8.33%)	⬆️
server/api/middlewares/rateLimitMiddleware.js	100.00% <ø> (ø)
server/api/routes.js	98.03% <ø> (ø)
server/api/setupRoutes.js	100.00% <100.00%> (ø)
server/api/websockets/index.js	79.36% <100.00%> (+21.03%)	⬆️
server/lib/house/house.arm.js	100.00% <100.00%> (ø)
server/lib/house/house.disarm.js	100.00% <100.00%> (ø)
server/lib/house/house.disarmWithCode.js	100.00% <100.00%> (ø)
... and 18 more

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

[relativeci]

Job #1968: Bundle Size — 8.98MiB (+0.77%).

617e3b7(current) vs 45c2f07 master#1964(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics   8 changes 4 regressions

	Current Job #1968	Baseline Job #1964
Initial JS	4.84MiB(+0.81%)	4.8MiB
Initial CSS	301.85KiB(+0.06%)	301.67KiB
Cache Invalidation	70.38%	53.7%
Chunks	51(+6.25%)	48
Assets	157(+1.95%)	154
Modules	1395(+0.87%)	1383
Duplicate Modules	20(+5.26%)	19
Duplicate Code	0.82%(+18.84%)	0.69%
Packages	124	124
Duplicate Packages	3	3

Bundle size by type   3 changes 3 regressions

	Current Job #1968	Baseline Job #1964
JS	6.49MiB (+1.05%)	6.42MiB
IMG	2.06MiB	2.06MiB
CSS	318.08KiB (+0.24%)	317.32KiB
Fonts	93.55KiB	93.55KiB
Other	16.06KiB (+2.56%)	15.66KiB
HTML	13.58KiB	13.58KiB

---

View job #1968 report View alarm-mode branch activity

[callemand]

This banner is pretty weird. I think we should add a box around

[callemand]

On "fullscreen=force" mode, why the "Mode Tablette" appear. I think we cannot make modification in "fullscreen=force", no ?

[callemand]

When I click on all button, My alarm is activated and desactived in the same time

Screen.Recording.2023-10-24.at.10.28.16.mov

[callemand]

Missing the "0", I cannot use a password like "1909"

[Pierre-Gilles]

@callemand Thanks for the review! 🙏

I fixed the console.log, the zero missing on the keypad and added a box around the tablet mode configuration.

For this:

It's completely normal, the "full color" state is on when the button is clickable, and if you are partially armed, you can either "fully arm", or "disarm".

On "fullscreen=force" mode, why the "Mode Tablette" appear. I think we cannot make modification in "fullscreen=force", no ?

There is no link between the fullscreen=force and tablet mode. You need the tablet mode button to be visible to configure the house the tablet is currently in. You can have a tablet not in full screen=force & a fullscreen=force not in tablet :)

[cicoub13]

Some typos in FR