Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring donation functionality #3436

Merged
merged 158 commits into from
Dec 26, 2023

Conversation

MohammadPCh
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2023 10:58am

Copy link
Member

@aminlatifi aminlatifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohammadPCh
It's huge! I just could overlook the code quality

src/components/AmountInput/AmountInput.tsx Show resolved Hide resolved
src/components/AmountInput/AmountInput.tsx Show resolved Hide resolved
Copy link
Member

@alireza-sharifpour alireza-sharifpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a chance to test out the PR with @MohammadPCh recently. We spotted a few small things, but no biggie - they were fixed on the fly! Big thanks to @MohammadPCh for the quick fixes and great teamwork.

@MohammadPCh MohammadPCh merged commit 36ca29e into superfluid-develop-branch Dec 26, 2023
3 checks passed
@MohammadPCh MohammadPCh deleted the recurring-donation-functionality branch December 26, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants