Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove uppercase transform from symbol selector #3416

Merged
merged 6 commits into from
Nov 26, 2023
Merged

remove uppercase transform from symbol selector #3416

merged 6 commits into from
Nov 26, 2023

Conversation

divine-comedian
Copy link
Contributor

fix #3355

@vercel Vercel
Copy link

vercel bot commented Nov 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 3:29pm

@divine-comedian divine-comedian mentioned this pull request Nov 8, 2023
Closed
@divine-comedian divine-comedian linked an issue Nov 8, 2023 that may be closed by this pull request
Donating USDC on Optimism for Giveth QF #3355
Closed
MohammadPCh
MohammadPCh requested changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@MohammadPCh MohammadPCh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @divine-comedian
But I think it may cause some problems in our code. and we should check all the tokens' logos again. so I suggest changing the name to upper case.
wdyt?

@divine-comedian
Copy link
Contributor Author

divine-comedian commented Nov 23, 2023 •
edited
Loading

@MohammadPCh I think its very nice if the tokens can show up with their proper capitalization.

wxDAI, USDC.e, agEUR - there are lots of instances of these capitalization differences

Do you know specifically where we might encounter errors from not having these token symbols capitlaized?

@MohammadPCh
Copy link
Collaborator

@divine-comedian, we display the tokens with their correct capitalization in the UI. However, for the logo files, we have converted all filenames to uppercase and also search for them in uppercase to ensure case sensitivity.

MohammadPCh
MohammadPCh approved these changes Nov 26, 2023
View reviewed changes
Copy link
Collaborator

@MohammadPCh MohammadPCh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @divine-comedian

@MohammadPCh MohammadPCh merged commit f0e8ebc into main Nov 26, 2023
2 checks passed
@MohammadPCh MohammadPCh deleted the fix-usdce-symbol branch November 26, 2023 12:49
@RamRamez RamRamez mentioned this pull request Jan 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohammadPCh MohammadPCh MohammadPCh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Donating USDC on Optimism for Giveth QF
2 participants
@divine-comedian @MohammadPCh