Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps to
jiff 0.2
and removeshumantime
in favor ofjiff
.Back when I first contributed the change to move to Jiff
in #31, Jiff didn't have a way of formatting durations
like
humantime
does. But Jiff does support thatnow.
One part I'm a little unsure about here is that prodash was still
trying to emit times even when
local-time
wasn't enabled, and itwas using
humantime
to do this. But now that Jiff is used for boththings, it probably doesn't make sense to have this fallback. (I think
it's also somewhat suspicious, since printing UTC time as if it were
local time is likely confusing.) In any case, I left it as it was,
except with using Jiff.
I tried running tests locally, but one of the tui rendering tests just
hung indefinitely for me.