Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch an error instead of crashing #139

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Catch an error instead of crashing #139

merged 1 commit into from
Nov 6, 2024

Conversation

yardenshoham
Copy link
Collaborator

@yardenshoham
Catch an error instead of crashing
98cf481 
It was rate-limiting.

Signed-off-by: Yarden Shoham <[email protected]>
jolheiser
jolheiser approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth revisiting with a retry at some point, but lgtm here

@yardenshoham yardenshoham merged commit 37da54d into main Nov 6, 2024
2 checks passed
@yardenshoham yardenshoham deleted the catch branch November 6, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yardenshoham @jolheiser