Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept string value as array #3

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Accept string value as array #3

merged 1 commit into from
Sep 19, 2024

Conversation

gregberge
Copy link
Contributor

@gregberge gregberge commented Sep 18, 2024 •
edited
Loading

To be honest, I am not 100% sure it's safe to accept that.

@gregberge gregberge force-pushed the validate-value-as-string branch from 2a964c2 to 2b930d0 Compare September 18, 2024 14:30
SamyPesse
SamyPesse approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR on this repository are hard to review and there is no example of the generated code, but I trust the tests :)

tests/gitbook.test.ts Outdated Show resolved Hide resolved
@gregberge gregberge force-pushed the validate-value-as-string branch from b0261b8 to abc3ed6 Compare September 19, 2024 07:22
@gregberge gregberge merged commit 13b1bef into main Sep 19, 2024
3 checks passed
@SamyPesse SamyPesse deleted the validate-value-as-string branch September 19, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamyPesse SamyPesse SamyPesse approved these changes

@emmerich emmerich Awaiting requested review from emmerich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregberge @SamyPesse