Fixes #2321. Fix code format overriding inline link styles #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does this by removing the gray font color of inline code blocks, but these were inconsistent with the gitbook editor anyway and I don't know how to both allow the text to have its own custom color without overriding the inline link font color.
🦋 Changeset detectedLatest commit: 3dbc717 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
reopened in #2673 to avoid issues of forked PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2321.
Does this by removing the gray font color of inline code blocks, but these were inconsistent with the gitbook editor anyway (plus I don't know how to allow the text to have its own custom color without overriding the inline link font color)
Also removes the inline-flex class name since it was responsible for overriding the underlined decoration of links. Results remain seemingly unchanged after removing it.
Before:
(Link in code font are indistinguishable from normal text)
After:
(Link in code font is correctly colored and underlined)