Migrating from UtilPack to NuGetUtils, take two

[stazz]

This is re-implementation of #1634 (which later was processed as #1645 ), since that got a bit too convoluted with respect of other changes done to GitVersion repository while the pull request was in development and under review.

Resolves #1634 and #1645.

[asbjornu]

This was much easier to review now, thank you so much for redoing it all. I have a few mostly syntactic requests, otherwise this looks good. 😃 👍

[stazz]

It seems we have a bit different coding styles! :) I love having each method parameter on its own line. In any case, I'll get on these as soon as I get time. These don't seem like a complex work, just a bit tedious.

The only thing I might be semi-disagreeing with is changing Boolean ValidateInput into void Validate() which throws, but that is a deeper philosophical discussion. And since this is your repository after all, let's go with the void Validate(). 👍

[stazz]

I've pushed commits which adher to the review discussion. I think the only non-clear things left are:

• Is it ok to have Input-classes (InputBase, InputWithCommonAdditionalProperties, and InputValidationException) in the same file with GitVersionTaskCommonFunctionality (ex GitVersionTaskBase)?
• I've just changed the name of GetWorkingDirectoryAndFileNameAndExtension to GetFileWriteInfo, I hope that's OK (didn't create any additional classes for this).

[asbjornu]

I think this looks good now. Can you please have a look as well, @dazinator and @arturcic? 

Is it ok to have Input-classes (InputBase, InputWithCommonAdditionalProperties, and InputValidationException) in the same file with GitVersionTaskCommonFunctionality (ex GitVersionTaskBase)?

I prefer one class per file, but it's not a deal-breaker.

I've just changed the name of GetWorkingDirectoryAndFileNameAndExtension to GetFileWriteInfo, I hope that's OK (didn't create any additional classes for this).

Fine by me.

[arturcic]

In the Infrastructure.props file please rename the properties that start with UtilPack with NuGetUtils to be consistent with the package name change

[asbjornu]

Thanks for your contributions and patiance, @stazz! 🙏

[stazz]

You're most welcome! Since dynamic assembly loading is extremely fragile business, let me know asap if you notice something funky going on. I did my best to do tests on this, but they were all manual, as I am not quite sure how to approach writing integration-level tests (which go on invoking dotnet build or dotnet msbuild on some project, etc) for this, so there might be still something I've missed. :)

[asbjornu]

@arturcic, now that you've started drafting release 5.0.0, would you like to postpone this to 5.0.1?

[arturcic]

Actually that was a test only, I'll remove the draft version, was checking the release notes generation and it seems it now works. I'll discard

[arturcic]

There are a couple of issues I want to address before the 5.0.0 version, and I think this PR should be included in 5.0.0