Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new attributes for fork endpoint #820

Open
wants to merge 2 commits into
base: 11.14
Choose a base branch
from

Conversation

maicol07
Copy link

@maicol07 maicol07 commented Oct 7, 2024

@MagnusHJensen
Copy link

Hey man, this is something I definitely could use right now.

Are you up for fixing the conflicts, but also not breaking the style guide? If not then I can make a new PR instead.

@maicol07
Copy link
Author

maicol07 commented Nov 8, 2024

Hey man, this is something I definitely could use right now.

Are you up for fixing the conflicts, but also not breaking the style guide? If not then I can make a new PR instead.

Hi, there aren't conflicts with the main branch of the original repo

@MagnusHJensen
Copy link

This PR fails with style conflicts, so yeah there is.

You have also modified the entire projects file where there is a string concat, so I would assume the authors/maintainers want that removed.

@maicol07
Copy link
Author

maicol07 commented Nov 8, 2024

Oh yes I can solve the style conflicts

@drumm
Copy link
Contributor

drumm commented Nov 18, 2024

This would be useful for me, too. It looks like the CI bot identified one remaining spacing issue.

I don't know if the maintainers will want to see the unrelated spacing-only changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants