fix(docker): add docker to the image so ggshield secret scan docker works #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an download images
fnareoh
force-pushed
the
garancegourdel/add_docker_to_docker_image
branch
from
1e820de to
f4aa18c
Compare
agateau-gg
requested changes
Oct 17, 2024
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
| && rm -rf /var/lib/apt/lists/*\ | ||
| && curl -fsSL https://get.docker.com | sh |
There was a problem hiding this comment.
I am not fond of blindly pulling from get.docker.com. Since we only use docker pull and docker save, would it be enough to get the distro version instead?
|
I'll go ahead an close this PR as it will probably be tackled differently. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Addresses #924, thanks a lot @cdupuis for raising the issue and providing a fix !
What has been done
This MR adds docker to the image so the command
ggshield secret scan docker alpinecan download the image and works out of the box.Validation
ggshield secret scan docker alpineworks on the new image.