Prepare project for semi-pinned tags for major version #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salome-voltz
force-pushed
the
salomevoltz/scrt-3458-ggshield-github-action-study-and-implement-semi-pinned
branch
6 times, most recently
from
037bf6c to
e49a78d
Compare
salome-voltz
changed the title
agateau-gg
requested changes
Jun 18, 2024
.github/workflows/tag.yml
Outdated
| @@ -3,13 +3,13 @@ name: Application Release | |||
| on: | |||
| push: | |||
| tags: | |||
| - "v*" | |||
| - "v1.*" | |||
There was a problem hiding this comment.
Do we need this change? If we ever make a v2 we would still need a similar CI workflow, no?
There was a problem hiding this comment.
We need to distinguish "v1" tag from version tags (like v1.20.0) here to make sure that we don't trigger a release when we push "v1" tag to its new position. I changed it to "v*.*", wdyt ?
There was a problem hiding this comment.
Oh right, good catch! "v*.*" sounds good. Can you add a comment about this?
salome-voltz
force-pushed
the
salomevoltz/scrt-3458-ggshield-github-action-study-and-implement-semi-pinned
branch
from
e49a78d to
c3e0aeb
Compare
salome-voltz
force-pushed
the
salomevoltz/scrt-3458-ggshield-github-action-study-and-implement-semi-pinned
branch
from
c3e0aeb to
c9712e0
Compare
agateau-gg
approved these changes
Jun 18, 2024
salome-voltz
deleted the
salomevoltz/scrt-3458-ggshield-github-action-study-and-implement-semi-pinned
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR aims to prepare this project for semi-pinned tags for major versions.
Tags will be created and updated in ggshield-tools release script.
This MR needs to be merged first.
Works with MR#22 on ggshield-tools. Needs to be merged first.