Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

280 add MLP CLI functions #412

Merged
merged 9 commits into from
Aug 19, 2024
Merged

280 add MLP CLI functions #412

merged 9 commits into from
Aug 19, 2024

Conversation

nmaarnio
Copy link
Collaborator

No description provided.

@nmaarnio nmaarnio linked an issue Jun 19, 2024 that may be closed by this pull request
Add MLP CLI functions #280
Closed
msorvoja
msorvoja requested changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@msorvoja msorvoja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good overall! There seems to be some redundant/repetitive code in cli.py, please check that out.

eis_toolkit/cli.py Outdated Show resolved Hide resolved
@nmaarnio
Copy link
Collaborator Author

Ready for another review

@nmaarnio nmaarnio mentioned this pull request Aug 13, 2024
Merged
@nmaarnio nmaarnio merged commit 1b83db6 into master Aug 19, 2024
3 checks passed
@nmaarnio nmaarnio deleted the 280-add-mlp-cli-functions branch August 19, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msorvoja msorvoja msorvoja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MLP CLI functions
2 participants
@nmaarnio @msorvoja