142 add create constant raster #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added necessary utility functions, already PRed in #98, but kept all other functions and files unchanged. FYI: There are some errors raising up when testing, which are from different other modules.
nmaarnio
reviewed
Jul 28, 2023
There was a problem hiding this comment.
This looks good overall. I am only wondering if the utility functions are strictly necessary, but if you have found out that they are needed or useful, I'll trust you. The public function is quite parameterized since it allows three modes with different parameter requirements, but I think having one interface for this functionality might be still the best option.
Accept review suggestion. Both ways make sense, I don´t have a strong opinion about this ;) Co-authored-by: Niko Aarnio <[email protected]>
|
Hey Nico, thank you for reviewing! 😀 I accepted your suggestion for unnesting the exceptions in Git, so it should be ready to go. |
nmaarnio
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a constant raster based on the users input value with three different options:
Merged it into three core- and one call-function.
The output will be an
integertype array, if bothconstantandnodatavalues are integers.If only
nodatais not integer, the metadata will be floating point but the array of integer type (to avoid useless decimal places when storing). In any other case, float64 will be assigned.Let me know what you think and if you would like to split even the call functions into separate functions or keep it as it is (then, probably some code parts would be redundant).
Cheers,
Micha