Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up everything not related to python #1447

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Clean up everything not related to python #1447

merged 3 commits into from
Oct 3, 2023

Conversation

Hartorn
Copy link
Member

@Hartorn Hartorn commented Oct 2, 2023 •
edited
Loading

Description

  • Removal of almost every files out of python-client folder (first commit)
  • Moving file from python-client to root folder (second commit)
  • Adapting build for new architecture

@Hartorn Hartorn self-assigned this Oct 2, 2023
@Hartorn Hartorn marked this pull request as ready for review October 2, 2023 16:07
@Hartorn Hartorn requested a review from a team as a code owner October 2, 2023 16:07
mattbit
mattbit approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@mattbit mattbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me!

.prettierrc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should keep this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually not that important after all

@Hartorn Hartorn merged commit 92f7654 into main Oct 3, 2023
9 checks passed
@Hartorn Hartorn deleted the cleanup-split branch October 3, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattbit mattbit mattbit approved these changes

@kevinmessiaen kevinmessiaen kevinmessiaen approved these changes

@rabah-khalek rabah-khalek Awaiting requested review from rabah-khalek

Assignees

@Hartorn Hartorn

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hartorn @mattbit @kevinmessiaen