Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSK-1797 Fix add test to test suite #1425

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Conversation

kevinmessiaen
Copy link
Member

Description

Fix add test to test suite from the giskard catalog due to invalid body being sent (migrated api to openapi)

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@kevinmessiaen kevinmessiaen changed the title Fix add test to test suite GSK-1797 Fix add test to test suite Sep 27, 2023
@linear
Copy link

linear bot commented Sep 27, 2023

GSK-1797 Cannot add test to a suite

When I try to add a test to a suite, I get this

image.png

To reproduce: https://giskardai-giskard.hf.space/main/projects/52/catalog/tests?suiteId=2

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Inokinoki Inokinoki merged commit 42750d5 into main Sep 27, 2023
11 checks passed
@Inokinoki Inokinoki deleted the fix/add_test_to_test_suite branch September 27, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants