Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PID lockfile issue for both Hugging Face Spaces and Docker #1403

Merged
merged 8 commits into from
Sep 15, 2023
Merged

Fix PID lockfile issue for both Hugging Face Spaces and Docker #1403

merged 8 commits into from
Sep 15, 2023

Conversation

Inokinoki
Copy link
Member

Description

Improve Dockerfile and supervisord config based on the lessons learnt from Hugging Face Spaces.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

andreybavt
andreybavt reviewed Sep 14, 2023
View reviewed changes
settings.gradle.kts Outdated Show resolved Hide resolved
andreybavt
andreybavt reviewed Sep 14, 2023
View reviewed changes
supervisord.conf Outdated Show resolved Hide resolved
@Inokinoki Inokinoki merged commit d6b6f6a into main Sep 15, 2023
3 checks passed
@Inokinoki Inokinoki deleted the improvement/fix-db-pid-lockfile-for-hf-and-docker branch September 15, 2023 12:29
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreybavt andreybavt andreybavt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Inokinoki @andreybavt