-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSK-1698] Remove legacy ML worker info and properties #1390
Conversation
Format `cli_server.py` by git pre-commit
GSK-1698 Adapt `giskard server expose` to the single exposed port
Previously we had to expose 2 ports: HTTP and TCP for worker connection Now that workers connect through the same port as the UI we should adapt the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Inokinoki I see there are still places that mention ports 40051 and 50051 remaining. Could you clean them up completely to avoid confusion?
You can use this to search for remaining cases from the root of giskard repo:
grep "(ml.?)?worker.?(port|host)|40051|50051" * -riE
Kudos, SonarCloud Quality Gate passed! |
Description
Related Issue
Type of Change
Checklist
CODE_OF_CONDUCT.md
document.CONTRIBUTING.md
guide.make codestyle
.