Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSK-1698] Remove legacy ML worker info and properties #1390

Merged
merged 12 commits into from
Sep 15, 2023

Conversation

Inokinoki
Copy link
Member

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@linear
Copy link

linear bot commented Sep 8, 2023

GSK-1698 Adapt `giskard server expose` to the single exposed port

Previously we had to expose 2 ports: HTTP and TCP for worker connection

Now that workers connect through the same port as the UI we should adapt the giskard server expose command

@Inokinoki Inokinoki marked this pull request as ready for review September 11, 2023 09:19
@Inokinoki Inokinoki self-assigned this Sep 15, 2023
Copy link
Contributor

@andreybavt andreybavt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Inokinoki I see there are still places that mention ports 40051 and 50051 remaining. Could you clean them up completely to avoid confusion?

You can use this to search for remaining cases from the root of giskard repo:

grep "(ml.?)?worker.?(port|host)|40051|50051" * -riE

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Inokinoki Inokinoki merged commit dd16b80 into main Sep 15, 2023
10 checks passed
@Inokinoki Inokinoki deleted the gsk-1698-giskard-server-expose-single-port branch September 15, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants