Test cases update for Patch Request #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manvityagi
requested changes
May 8, 2021
| @@ -111,6 +112,14 @@ describe('OpportunityManager', function () { | |||
| queryObject, | |||
| updatingobject | |||
| ); | |||
|
|
|||
There was a problem hiding this comment.
@Kashish0423 Test the API on postman yourself, see what it does when
- 12-bit incorrect id is passed
- lesser or greater than 12 bit id is passed
See the API Response in both cases and write the test cases accordingly.
Also, the test updateOpportunity has to be updated with more test cases, you wont have multiple describe blocks, instead multiple it blocks.
In tests/managers/opportunity-test.js, tests/services/opportunity-test.js , tests/controllers/opportunity-test.js, the test describe('updateOpportunity is to be updated with more test cases i.e more it blocks.
There was a problem hiding this comment.
Okay mam on it , I will try to get it done asap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @Manvityagi mam, please have a look at the code and let me know if there are more changes that need to be done , I will be happy to get it done asap