-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cases update for Patch Request #101
base: develop
Are you sure you want to change the base?
Conversation
@@ -111,6 +112,14 @@ describe('OpportunityManager', function () { | |||
queryObject, | |||
updatingobject | |||
); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kashish0423 Test the API on postman yourself, see what it does when
- 12-bit incorrect id is passed
- lesser or greater than 12 bit id is passed
See the API Response in both cases and write the test cases accordingly.
Also, the test updateOpportunity
has to be updated with more test cases, you wont have multiple describe blocks
, instead multiple it
blocks.
In tests/managers/opportunity-test.js
, tests/services/opportunity-test.js
, tests/controllers/opportunity-test.js
, the test describe('updateOpportunity
is to be updated with more test cases i.e more it
blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay mam on it , I will try to get it done asap
Hello @Manvityagi mam, please have a look at the code and let me know if there are more changes that need to be done , I will be happy to get it done asap