-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 1.21.1 #198
Conversation
Keeping in draft until pipeline issue is fixed and I've tested all rules affected by breaking changes |
…king changes in 1.21
… method removal in block code
c29864b
to
07976b5
Compare
Fixed one issue to do with instant mining where the game crashed Two rules to fix:
|
07976b5
to
7e38532
Compare
These rules have now been fixed. Introduced a single mixin for the flower pot rules to manage the order instead of using mixin shifts. This will be more stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like just DropAllXpOnPlayerDeath needs to be fixed.
src/main/java/carpetaddonsnotfound/mixins/LivingEntity_DropAllXpOnPlayerDeathMixin.java
Show resolved
Hide resolved
… remove methods and to not used repeated code
…_PortalSpectatorDelayMixin due to portal interaction changes
… mixin Fixes broken code due to a 1.20.5 change with networking. The networking code was too complicated for a single use case and the client and server players would always execute the same movement code regardless so the rule could be implemented this way perfectly fine.
…served by a manager class
99f2776
to
4db5106
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR introduces a support change for Minecraft (MC) 1.21.1. This directly bumps main from 1.20.4 to 1.21.1 so it includes fixes to 1.20.5 & 1.20.6 breaking changes. A PR to update the 1.20.x branch to 1.20.6 will be done separately.
Full list of changes:
BlockBreakingSpeedRatioCalculator
following enchantment code changes in MCEndFrameBlock_EyeToggleMixin
withEnderEyeItem_EyeToggleMixin
following removal of deprecated methods inBlock
codePlayerEntity_PortalSpectactorDelayMixin
withNetherPortalBlock_PortalBlockMixin
following portal interaction changes