Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove montgomery reduction #12

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

GiacomoPope
Copy link
Owner

Pretty decent speed up for just deleting code:

Jack: kyber-py % python3 benchmark_kyber.py                 
----------------------------------------------------------------------
 Params    | keygen | keygen/s | encap  | encap/s  | decap  | decap/s
----------------------------------------------------------------------
 Kyber512  |  5.59ms    178.75    8.32ms    120.12   13.40ms     74.63
 Kyber768  |  8.10ms    123.53   11.82ms     84.58   18.78ms     53.26
 Kyber1024 | 11.71ms     85.39   16.30ms     61.37   25.45ms     39.29
Jack: kyber-py % git checkout remove_montgomery_reduction
Switched to branch 'remove_montgomery_reduction'
Jack: kyber-py % python3 benchmark_kyber.py              
----------------------------------------------------------------------
 Params    | keygen | keygen/s | encap  | encap/s  | decap  | decap/s
----------------------------------------------------------------------
 Kyber512  |  4.85ms    206.27    7.07ms    141.46   11.59ms     86.31
 Kyber768  |  6.93ms    144.21   10.11ms     98.94   16.49ms     60.63
 Kyber1024 |  9.88ms    101.19   13.76ms     72.67   22.22ms     45.01

@GiacomoPope GiacomoPope merged commit 5390ada into main Jul 18, 2024
4 checks passed
@GiacomoPope GiacomoPope deleted the remove_montgomery_reduction branch July 18, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant