-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests for macOS arp fix #96
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage ? 87.77%
=======================================
Files ? 3
Lines ? 924
Branches ? 0
=======================================
Hits ? 811
Misses ? 113
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Python 2.7 test setting seems not to be functional anymore |
@raymanP Hey, really sorry this languished for so long. I had a lot going on at the start of the year and this fell through the cracks. 2.7 has been removed from the tests in main, if you pull those in this branch should pass. |
Hi @GhostofGoes , no problem, good you're back! |
Yeah, it's due to them being old enough that their OpenSSL version is too outdated. I'm just going to remove 3.5 and 3.6 from the tests as well as I'll be dropping support for them later anyway. |
The MacOS tests for 3.7+ shoudn't be failing though. Might be an issue with GitHub actions...will see what happens on main. |
Yup, it was due to Apple Silicon. Give it another try. |
Wonderful, everythin passed! ) |
All Submissions:
Code changes:
black getmac tests
tox -e check
tox
Summary of changes: