Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for macOS arp fix #96

Merged
merged 8 commits into from
Jun 3, 2024
Merged

Fix tests for macOS arp fix #96

merged 8 commits into from
Jun 3, 2024

Conversation

raymanP
Copy link
Contributor

@raymanP raymanP commented Dec 22, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

Code changes:

  • Did you format your code with Black?
    • black getmac tests
  • Are the linting checks passing?
    • tox -e check
  • Do all tests pass locally?
    • tox
  • Have you updated the CHANGELOG with a summary of your change?
  • Did you add your name to the contributors list in the README?

Summary of changes:

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@d7124ed). Learn more about missing BASE report.

Current head d381187 differs from pull request most recent head 6af6f2d

Please upload reports for the commit 6af6f2d to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage        ?   87.77%           
=======================================
  Files           ?        3           
  Lines           ?      924           
  Branches        ?        0           
=======================================
  Hits            ?      811           
  Misses          ?      113           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raymanP
Copy link
Contributor Author

raymanP commented Dec 23, 2023

Python 2.7 test setting seems not to be functional anymore
Could be good to remove it's support here as done in 1.0.0-wip?

@GhostofGoes
Copy link
Owner

@raymanP Hey, really sorry this languished for so long. I had a lot going on at the start of the year and this fell through the cracks. 2.7 has been removed from the tests in main, if you pull those in this branch should pass.

@GhostofGoes GhostofGoes self-assigned this Jun 1, 2024
@raymanP
Copy link
Contributor Author

raymanP commented Jun 2, 2024

Hi @GhostofGoes , no problem, good you're back!
I updated, however, it seems there is a general CI problem for Python 3.5 and for the macos tests now.
I don't know how to handle this. Hope u can find time to adress this.

@GhostofGoes
Copy link
Owner

Hi @GhostofGoes , no problem, good you're back! I updated, however, it seems there is a general CI problem for Python 3.5 and for the macos tests now. I don't know how to handle this. Hope u can find time to adress this.

Yeah, it's due to them being old enough that their OpenSSL version is too outdated. I'm just going to remove 3.5 and 3.6 from the tests as well as I'll be dropping support for them later anyway.

@GhostofGoes
Copy link
Owner

The MacOS tests for 3.7+ shoudn't be failing though. Might be an issue with GitHub actions...will see what happens on main.

@GhostofGoes
Copy link
Owner

Yup, it was due to Apple Silicon. Give it another try.

@raymanP
Copy link
Contributor Author

raymanP commented Jun 2, 2024

Wonderful, everythin passed! )

@GhostofGoes GhostofGoes merged commit cc65cdc into GhostofGoes:main Jun 3, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants