Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure sessions are removed when a transfer packet is sent or they exit without the form #86

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

Konicai
Copy link
Member

@Konicai Konicai commented Aug 5, 2024

  • Removes usage of GeyserSession from the storage and server managers, instead using Connection api
  • Don't allow GC to start on Geyser instances with auth-type: offline since it breaks GeyserConnect and doesn't have any affect on what kind of servers you can connect to.
  • Restore the original packet handler when a transfer packet is sent to reduce likelihood of breakages
  • Ensure session disconnect occurs when onDisconnect is called on the GC custom PacketHandler, by also calling the original packet handler
  • The previous two points combined will ensure that the session is removed when it wasn't previously:
    • A transfer packet is sent to them
    • They leave GC by force closing the client
    • They leave GC by spamming the escape key to access the client settings and leaving from there

This does not fix the issue where two clients can join with the same account, which should probably be added as an additional check within Geyser.

I have tested this on my local testing instance, transferring to the geyser test server, and also joining it as a java player using GC. Would appreciate if someone could also do some as a double check because I really don't want to accidentally break the public GC :)

@rtm516 rtm516 merged commit 59bfd77 into GeyserMC:master Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants