Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure GC works with later firing of SessionInitializeEvent #83

Merged
merged 1 commit into from
May 10, 2024
Merged

Ensure GC works with later firing of SessionInitializeEvent #83

merged 1 commit into from
May 10, 2024

Conversation

onebeastchris
Copy link
Member

See here: GeyserMC/Geyser#4604

Changes for GC:

  • the packet handler is replaced at a later point in time, meaning that the loginpacket handler can be removed (with the functionality there being moved to the session init event listener).
  • Need to forward ResourcePackChunkRequestPacket and ResourcePackClientResponsePacket manually to the original packet listener, as it otherwise causes NPE's caused by GC taking over the packet handler

@onebeastchris onebeastchris merged commit 9733781 into GeyserMC:master May 10, 2024
1 check passed
@onebeastchris onebeastchris deleted the api-changes branch May 10, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@onebeastchris