Fix server switching with larger render distances #2168
+108
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the attached comment in DimensionUtils for more information.
…erenderdistancedimfix
rtm516
approved these changes
Apr 24, 2021
|
May I ask when it will be merged? |
|
I've been meaning to get some more testing going and possibly clean up the PR a bit - this feels hacky but hackiness is better than unworkable behavior. |
|
Is this pr going to be merged? Or is it solved by other means? |
|
Is this still on the work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server only started sending its render distance during 1.14. ViaVersion compensates by sending 64 as the render distance, always - but this can choke up Bedrock in various ways. This PR fixes two separate issues related: