Fixed Beans Compiler path handling on some systems. #334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the path of an asset starts with a
/
, e.g./wp-includes/js/jquery/jquery.js
, theget_internal_content()
method of the Beans Compiler cannot resolve this to a valid path on Windows and some Ubuntu systems (there might be others).This does not seem to be a regression in version 1.5.
It doesn't work for me in version 1.4 on Windows.
This PR adds additional
file_exists
checks toget_internal_content()
.The first one checks if the path starts with
wp-
and then adds a.
to the beginning of the path and runs it throughbeans_sanitize_path()
.The second one runs a still unresolved path through
beans_path_to_url()
and thenbeans_url_to_path()
to catch edge cases not covered before, e.g. if the wp-content directory has been changed.Please see #332 for the discussion on the approach.
Special thanks to @iCaspar 💯
closes #332