Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]Introduce CallKit availability policies #611

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

ipavlidakis
Copy link
Collaborator

@ipavlidakis ipavlidakis commented Dec 2, 2024

🔗 Issue Links

Resolves https://linear.app/stream/issue/IOS-551/disable-callkit-in-china-by-default

🎯 Goal

Provide a consistent and easy way for CallKit to be enabled/disabled based on availability rules (predefined and custom).

🛠 Implementation

The SDK by default provides 2 policies:

  • always: CallKit will be marked as available in every case
  • regionBased: CallKit will be marked as unavailable in China region (as identifier by Locale identifiers "CN" and "CHN").

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS) (PR can be found here)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Dec 2, 2024
@ipavlidakis ipavlidakis self-assigned this Dec 2, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner December 2, 2024 16:34
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Dec 2, 2024

SDK Size

title develop branch diff status
StreamVideo 7.6 MB 7.61 MB +18 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB 0 KB 🟢
StreamVideoUIKit 2.31 MB 2.31 MB 0 KB 🟢
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@ipavlidakis ipavlidakis force-pushed the feature/disable-callkit-on-unsupported-regions branch from 06cd139 to 400774a Compare December 2, 2024 17:08
@ipavlidakis ipavlidakis enabled auto-merge (squash) December 2, 2024 19:00
Copy link
Collaborator

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice implementation ✅

@ipavlidakis ipavlidakis merged commit 2ee1c89 into develop Dec 2, 2024
14 checks passed
@ipavlidakis ipavlidakis deleted the feature/disable-callkit-on-unsupported-regions branch December 2, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants