Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]Recording state when failed #476

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

ipavlidakis
Copy link
Collaborator

🔗 Issue Links

Provide all JIRA tickets and/or GitHub issues related to this PR, if applicable.

🎯 Goal

Describe why we are making this change.

📝 Summary

Provide bullet points with the most important changes in the codebase.

🛠 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

🎁 Meme

Provide a funny gif or image that relates to your work on this pull request. (Optional)

@ipavlidakis ipavlidakis added the bug Something isn't working label Jul 31, 2024
@ipavlidakis ipavlidakis self-assigned this Jul 31, 2024
@ipavlidakis ipavlidakis requested a review from a team as a code owner July 31, 2024 12:41
@ipavlidakis ipavlidakis enabled auto-merge (squash) July 31, 2024 12:45
Copy link

1 Warning
⚠️ Please be sure to complete the Contributor Checklist in the Pull Request description

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamVideo 7.11MB 7.11MB 0.0MB 🟢
StreamVideoSwiftUI 2.18MB 2.18MB 0.0MB 🟢
StreamVideoUIKit 2.32MB 2.32MB 0.0MB 🟢

Copy link

@ipavlidakis ipavlidakis merged commit 41b35ef into develop Jul 31, 2024
13 checks passed
@ipavlidakis ipavlidakis deleted the fix/recording-failed-state branch July 31, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants